This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
OpenPypeV3: Add key parent asset to path templating construction #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is much better than adding |
|
Blocked by #2157 |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./openpype/hosts/flame/api/lib.py:50:28: B008: Do not perform function calls ...
./openpype/hosts/flame/api/lib.py:50:28: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 363, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./openpype/hosts/flame/api/lib.py:50:28: B008: Do not perform function calls ...
./openpype/hosts/flame/api/lib.py:50:28: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 363, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
ClementHector
force-pushed
the
add-key-parent-asset-in-path-templating
branch
2 times, most recently
from
2d08d12
to
2fec627
Compare
ClementHector
force-pushed
the
add-key-parent-asset-in-path-templating
branch
from
2fec627
to
41a02fd
Compare
|
@iLLiCiTiT Hound is blocking but I don't know why, can you watch? |
@mkolar interesting hound is houding because of code which is not added, modified or affected by this PR |
Parent key modifications
|
Ready to merge but avalon's PR must be first ynput/avalon-core#392 (and Ellipsanime/avalon-core#1). |
iLLiCiTiT
reviewed
Dec 2, 2021
@ClementHector I just want to remind that this is ready but avalon-core PR must be merged first. And the PR is not ready to merge yet, |
|
@iLLiCiTiT I think it's good now. |
iLLiCiTiT
approved these changes
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple proposal to add the parent in the path templating construction.